Defer acclogp_assume!! and acclogp_observe!! to child context
#574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7697478498
💛 - Coveralls |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #574 +/- ##
==========================================
+ Coverage 84.28% 84.32% +0.03%
==========================================
Files 26 26
Lines 3175 3183 +8
==========================================
+ Hits 2676 2684 +8
Misses 499 499 ☔ View full report in Codecov by Sentry. |
devmotion
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Yes, to me it seems we rather want the behaviour in this PR. Of course, would be nice to have tests for this behaviour but I imagine this could be a bit cumbersome to set up (e.g. by defining dummy contexts that allow us to trace the path of execution, e.g., by storing something in the context when a specific method is called...).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #565: since
acclogp_assume!!andacclogp_observe!!are meant to allow very fine control over how these logpdfs are accumulated, we should IMO try our best to find a context which overloads the behavior ofacclogp_assume!!andacclogp_observe!!rather than just immediately going to the defaultassume!!(which is what do atm).Hence this PR.